Inline dynamic import transform #15026
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolo-ribaudo
force-pushed
the
inline-dynamic-import-transform
branch
2 times, most recently
from
8d317e1
to
2701f09
Compare
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/53171/ |
nicolo-ribaudo
force-pushed
the
inline-dynamic-import-transform
branch
2 times, most recently
from
589e158
to
24d854b
Compare
nicolo-ribaudo
force-pushed
the
inline-dynamic-import-transform
branch
from
24d854b
to
1f93eb7
Compare
JLHwung
approved these changes
Oct 16, 2022
liuxingbaoyu
approved these changes
Oct 17, 2022
texpert
added a commit
to texpert/rails_6_rss_reader
that referenced
this pull request
Nov 8, 2022
…amic import transform code has been refactored and inlined - see babel/babel#15026
github-actions
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should start working on babel/rfcs#4 (cc @JLHwung), but having the dynamic import transform in a separate repository makes it very hard to do so (aka impossible) because:
This PR "inlines" https://github.com/airbnb/babel-plugin-dynamic-import-node/blob/master/src/utils.js (actually, I rewrote most of the code to adapt it to our style and to remove some parts only needed for compatibility with older Babel major versions).