Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compilation of parameters in async generators #15146

Merged
merged 2 commits into from Nov 7, 2022

Conversation

nicolo-ribaudo
Copy link
Member

@nicolo-ribaudo nicolo-ribaudo commented Nov 5, 2022

Q                       A
Fixed Issues? Fixes #15145
Patch: Bug Fix? Yes
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

We cannot compile async generators to async functions, because async generators don't return promises.

@nicolo-ribaudo nicolo-ribaudo added PR: Bug Fix 🐛 A type of pull request used for our changelog categories i: regression Spec: Async Generators labels Nov 5, 2022
@babel-bot
Copy link
Collaborator

babel-bot commented Nov 5, 2022

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/53374/

@liuxingbaoyu
Copy link
Member

Hint: CI errors are related.

@nicolo-ribaudo nicolo-ribaudo merged commit 54deff9 into babel:main Nov 7, 2022
@nicolo-ribaudo nicolo-ribaudo deleted the fix-15145 branch November 7, 2022 11:20
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Feb 7, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
i: regression outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Bug Fix 🐛 A type of pull request used for our changelog categories Spec: Async Generators
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Async generators with default parameters compile to invalid code
4 participants