chore: Migrating third-party parser tests to MakeJS #15431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
liuxingbaoyu
commented
Feb 16, 2023
•
liuxingbaoyu
commented
| Q | A |
|---|---|
| License | MIT |
Makefile.source.mjs
Outdated
| @@ -389,6 +389,73 @@ target["test-cov"] = function () { | |||
| ); | |||
| }; | |||
|
|
|||
| function getParserTestsCommit(id) { | |||
| const content = readFileSync("./Makefile", "utf8"); | |||
| const commit = content.match(new RegExp(`${id}_COMMIT = (\\w{40})`))[1]; | |||
There was a problem hiding this comment.
Do we still need to store these commits in Makefile?
There was a problem hiding this comment.
I tend to keep them so that we don't need to regenerate Makefile.js.
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/53935/ |
Makefile.source.mjs
Outdated
Comment on lines
440
to
456
| const dir = "./build/flow"; | ||
|
|
||
| shell.rm("-rf", dir); | ||
| shell.mkdir("-p", "build"); | ||
|
|
||
| exec("git", [ | ||
| "clone", | ||
| "--filter=blob:none", | ||
| "--sparse", | ||
| "--single-branch", | ||
| "--shallow-since=2021-05-01", | ||
| "https://github.com/facebook/flow.git", | ||
| dir, | ||
| ]); | ||
|
|
||
| exec("git", ["sparse-checkout", "set", "src/parser/test/flow"], dir); | ||
| exec("git", ["checkout", "-q", getParserTestsCommit("FLOW")], dir); |
There was a problem hiding this comment.
Since the contents of these three commands is almost the same, could we extract them to a bootstrapParserTests(dir, repoURL, repoDir, commit) function?
There was a problem hiding this comment.
I ignored the --shallow-since difference, it doesn't matter.
JLHwung
approved these changes
Feb 16, 2023
JLHwung
reviewed
Feb 16, 2023
Co-authored-by: Huáng Jùnliàng <jlhwung@gmail.com>
nicolo-ribaudo
approved these changes
Feb 18, 2023
github-actions
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.