[ts] treat single type param with a constraint as unambiguous #15436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/53945/ |
JLHwung
approved these changes
Feb 17, 2023
| @@ -1,2 +1,3 @@ | |||
| <T,>() => 1; | |||
| <T,>(x) => 1; | |||
| <T extends unknown>(x) => 1; | |||
There was a problem hiding this comment.
Can you also add
<T = unknown,>(x) => 1It should be unambiguous because of the trailing comma.
| @@ -1,2 +1,3 @@ | |||
| <T>() => 1; | |||
| <T>(x) => 1; | |||
| <T = unknown>(x) => 1; | |||
There was a problem hiding this comment.
Heh, had the same doubt - i dont know. It’s treated as ambigous by TS though 🤷♂️
There was a problem hiding this comment.
This sounds like a bug, but yeah we should match their behavior.
nicolo-ribaudo
approved these changes
Feb 18, 2023
nicolo-ribaudo
changed the title
nicolo-ribaudo
deleted the
fix/disallowAmbiguousJSXLike-allow-with-constraint
branch
github-actions
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1, Fixes #2This matches the TS behavior. I verified that constraints make this unambiguous (but defaults don't)