Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Attempt to fix test262 failed #15438

Merged
merged 1 commit into from Feb 20, 2023
Merged

chore: Attempt to fix test262 failed #15438

merged 1 commit into from Feb 20, 2023

Conversation

liuxingbaoyu
Copy link
Member

@liuxingbaoyu liuxingbaoyu commented Feb 18, 2023 •
edited by gitpod-io bot

Q                       A
Fixed Issues? Fixes #1, Fixes #2
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

@babel-bot
Copy link
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/53963/

@nicolo-ribaudo
Copy link
Member

🤞

@liuxingbaoyu
Copy link
Member Author

The problem seems to be no longer reproducible. :)

@nicolo-ribaudo
Copy link
Member

Ohh thanks :)

@liuxingbaoyu
Copy link
Member Author

Ah, I mean even without this PR issue doesn't appear anymore.🤦‍♂️

@nicolo-ribaudo
Copy link
Member

For context: the root cause of the problem was that, before cloning, actions/checkout makes an API call to get the name of the default branch. Hard-coding its name avoids that API call, that was failing due to rate limiting.

@nicolo-ribaudo
Copy link
Member

Ah, I mean even without this PR issue doesn't appear anymore.man_facepalming

Oh, I didn't notice it 😅

@nicolo-ribaudo
Copy link
Member

Well, if it happens again I'll restart the CI jobs on this PR.

@nicolo-ribaudo
Copy link
Member

This is still avoiding an unnecessary API call (Determining the default branch), it might be worth to merge it anyway.

@nicolo-ribaudo
Copy link
Member

nicolo-ribaudo commented Feb 18, 2023 •
edited

Rate limited again: https://github.com/babel/babel/actions/runs/4212001194/jobs/7310741029

I restarted CI on this PR.

@nicolo-ribaudo nicolo-ribaudo merged commit 834ab07 into babel:main Feb 20, 2023
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Jul 23, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JLHwung JLHwung JLHwung approved these changes

@nicolo-ribaudo nicolo-ribaudo nicolo-ribaudo approved these changes

Assignees
No one assigned
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@liuxingbaoyu @babel-bot @nicolo-ribaudo @JLHwung