Do not run flaky cli tests locally by default #15928
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I remember it seems like after that we merged another PR to fix them. But it doesn’t matter, this PR is good for me. |
|
By the way, if there is anything I can do in citgm, please feel free to cc! |
nicolo-ribaudo
force-pushed
the
cli-flaky-test
branch
from
dbffb71
to
2403e27
Compare
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/55354/ |
JLHwung
approved these changes
Sep 5, 2023
github-actions
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1, Fixes #2There is this very annoying test that fails whenever I run all the tests locally, but not if I run it individually. I'm not the only one affected by this: #14599 (comment)
We are trying to run Babel as part of Node.js' smoke tests suite (nodejs/citgm#628), and it triggers this error. Let's disable it by default, and only run it on CI. There is an env flag to run it locally.