Avoid one-off custom expect matcher to compare files #15951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/55425/ |
nicolo-ribaudo
force-pushed
the
minor-cleanup
branch
2 times, most recently
from
27636fa
to
205b5f6
Compare
nicolo-ribaudo
force-pushed
the
minor-cleanup
branch
from
205b5f6
to
40d6f3f
Compare
JLHwung
approved these changes
Sep 11, 2023
liuxingbaoyu
approved these changes
Sep 11, 2023
github-actions
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1, Fixes #2I noticed we had a custom matcher that we use only once -- inlining it cleans up the code a bit.