Partial revert of changes needed to build with Babel 8 #16036
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/55650/ |
liuxingbaoyu
approved these changes
Oct 12, 2023
github-actions
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR isn't actually necessary for us, other than for using
@babel/core/cjs-proxy.cjsin a real-world case and thus making sure that it does not break (rather than just relying on unit tests).However, I was trying to use Babel as an example of a big project that requires no changes for their users when going from CJS to ESM, and I noticed that in #15846 we did require a change: we had to remove the
require("@babel/core"). However, thanks to #15137 we don't actually need to do that and I'd like to show it :)