Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pack published packages in e2e tests #16089

Merged
merged 2 commits into from Nov 7, 2023
Merged

Pack published packages in e2e tests #16089

merged 2 commits into from Nov 7, 2023

Conversation

JLHwung
Copy link
Contributor

@JLHwung JLHwung commented Nov 6, 2023

Q                       A
Fixed Issues? Improves e2e test runtime by replacing 300 HTTP requests by a single HTTP request
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

It could take 15 mins to upload the published packages in our current e2e tests: https://github.com/babel/babel/actions/runs/6774681164/job/18412314343?pr=16069

In this PR we pack the published packages before upload and unpack them after download.

@babel-bot
Copy link
Collaborator

babel-bot commented Nov 6, 2023 •
edited

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/55789/

nicolo-ribaudo
nicolo-ribaudo approved these changes Nov 7, 2023
View reviewed changes
Copy link
Member

@nicolo-ribaudo nicolo-ribaudo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:)

liuxingbaoyu
liuxingbaoyu approved these changes Nov 7, 2023
View reviewed changes
Copy link
Member

@liuxingbaoyu liuxingbaoyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm surprised actions/upload-artifact doesn't provide this.

@JLHwung JLHwung merged commit fdc025e into babel:main Nov 7, 2023
48 checks passed
@JLHwung JLHwung deleted the pack-verdaccio-workspace branch November 7, 2023 00:26
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Feb 6, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nicolo-ribaudo nicolo-ribaudo nicolo-ribaudo approved these changes

@liuxingbaoyu liuxingbaoyu liuxingbaoyu approved these changes

Assignees
No one assigned
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@JLHwung @babel-bot @nicolo-ribaudo @liuxingbaoyu