chore: Helper changes for Babel 8 #16209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/56120/ |
fisker
reviewed
Jan 10, 2024
| "alongside 'file.availableHelper()'.", | ||
| ); | ||
| if (!process.env.BABEL_8_BREAKING) { | ||
| if (key === "helpersNamespace") { |
There was a problem hiding this comment.
There was a problem hiding this comment.
Thanks for reminding!
This is a special case. :)
Line 499 in 0085301
We use a custom plugin to remove it on release.
There was a problem hiding this comment.
Actually, since #15961 the custom plugin should support doing
if (!process.env.BABEL_8_BREAKING && key === "helpersNamespace") {:)
nicolo-ribaudo
approved these changes
Jan 11, 2024
liuxingbaoyu
added
the
PR: Internal (next major) 🏠
liuxingbaoyu
changed the title
liuxingbaoyu
force-pushed
the
babel8-helper
branch
from
56d64f0
to
e94edf0
Compare
JLHwung
approved these changes
Jan 31, 2024
liuxingbaoyu
added a commit
to liuxingbaoyu/babel
that referenced
this pull request
Mar 5, 2024
github-actions
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1, Fixes #2The only change is that we no longer access
node._loc.To be honest, just removing these two methods is fine for me too.