Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add base input to create-pr action #16250

Merged
merged 1 commit into from Jan 31, 2024
Merged

add base input to create-pr action #16250

merged 1 commit into from Jan 31, 2024

Conversation

JLHwung
Copy link
Contributor

@JLHwung JLHwung commented Jan 30, 2024

Q                       A
Fixed Issues? The types-docs-update workflow is failing because the PR base is incorrect: https://github.com/babel/babel/actions/runs/7657776780/job/20869526215#step:5:56
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

Pending babel/actions#28.

nicolo-ribaudo
nicolo-ribaudo approved these changes Jan 31, 2024
View reviewed changes
Copy link
Member

@nicolo-ribaudo nicolo-ribaudo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really looking forward the day this will work :)

@nicolo-ribaudo nicolo-ribaudo merged commit a2b447e into babel:main Jan 31, 2024
49 checks passed
@nicolo-ribaudo nicolo-ribaudo deleted the add-base-input-release-docs-workflow branch January 31, 2024 11:12
liuxingbaoyu pushed a commit to liuxingbaoyu/babel that referenced this pull request Mar 5, 2024
@JLHwung @liuxingbaoyu
add base input to create-pr action (babel#16250)
f322daf
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label May 2, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nicolo-ribaudo nicolo-ribaudo nicolo-ribaudo approved these changes

@liuxingbaoyu liuxingbaoyu liuxingbaoyu approved these changes

Assignees
No one assigned
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@JLHwung @nicolo-ribaudo @liuxingbaoyu