New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove logic for deprecated decorator versions from Babel 8 #16256
Merged
JLHwung
merged 5 commits into
babel:feat-7.24.0/decorators
from
JLHwung:decorator-cleanup
Feb 4, 2024
Merged
Remove logic for deprecated decorator versions from Babel 8 #16256
JLHwung
merged 5 commits into
babel:feat-7.24.0/decorators
from
JLHwung:decorator-cleanup
Feb 4, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JLHwung
added
the
PR: Internal 🏠
A type of pull request used for our changelog categories
label
Feb 1, 2024
9 tasks
nicolo-ribaudo
approved these changes
Feb 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest reviewing commit-by-commit.
liuxingbaoyu
approved these changes
Feb 4, 2024
nicolo-ribaudo
added
PR: Internal (next major) 🏠
A type of pull request used for our changelog categories for next major release
and removed
PR: Internal 🏠
A type of pull request used for our changelog categories
labels
Feb 4, 2024
JLHwung
added a commit
that referenced
this pull request
Feb 14, 2024
* refactor: reuse staticFieldInitializerAssignments * refactor: rename fieldInitializerAssignments to expressions * test: expand replacement-static-installed-on-correct-class case * chore: maybePrivateBrandName typo * wrap version "2023-05" check within Babel 7 branch
nicolo-ribaudo
pushed a commit
that referenced
this pull request
Feb 26, 2024
* refactor: reuse staticFieldInitializerAssignments * refactor: rename fieldInitializerAssignments to expressions * test: expand replacement-static-installed-on-correct-class case * chore: maybePrivateBrandName typo * wrap version "2023-05" check within Babel 7 branch
nicolo-ribaudo
pushed a commit
that referenced
this pull request
Feb 27, 2024
* refactor: reuse staticFieldInitializerAssignments * refactor: rename fieldInitializerAssignments to expressions * test: expand replacement-static-installed-on-correct-class case * chore: maybePrivateBrandName typo * wrap version "2023-05" check within Babel 7 branch
nicolo-ribaudo
pushed a commit
that referenced
this pull request
Feb 27, 2024
* refactor: reuse staticFieldInitializerAssignments * refactor: rename fieldInitializerAssignments to expressions * test: expand replacement-static-installed-on-correct-class case * chore: maybePrivateBrandName typo * wrap version "2023-05" check within Babel 7 branch
github-actions
bot
added
the
outdated
A closed issue/PR that is archived due to age. Recommended to make a new issue
label
May 6, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
outdated
A closed issue/PR that is archived due to age. Recommended to make a new issue
PR: Internal (next major) 🏠
A type of pull request used for our changelog categories for next major release
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a follow-up to #16242, in this PR we wrap the versions check within Babel 7 check for those deprecated decorator versions. This PR also fixes some typo and expands current test cases.