Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove logic for deprecated decorator versions from Babel 8 #16256

Merged
merged 5 commits into from Feb 4, 2024

Conversation

JLHwung
Copy link
Contributor

@JLHwung JLHwung commented Feb 1, 2024

Q                       A
Fixed Issues? #16242 (comment)
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

As a follow-up to #16242, in this PR we wrap the versions check within Babel 7 check for those deprecated decorator versions. This PR also fixes some typo and expands current test cases.

@JLHwung JLHwung added the PR: Internal 🏠 A type of pull request used for our changelog categories label Feb 1, 2024
Copy link
Member

@nicolo-ribaudo nicolo-ribaudo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest reviewing commit-by-commit.

@nicolo-ribaudo nicolo-ribaudo added PR: Internal (next major) 🏠 A type of pull request used for our changelog categories for next major release and removed PR: Internal 🏠 A type of pull request used for our changelog categories labels Feb 4, 2024
@JLHwung JLHwung merged commit 352383f into babel:feat-7.24.0/decorators Feb 4, 2024
49 checks passed
@JLHwung JLHwung deleted the decorator-cleanup branch February 4, 2024 15:24
JLHwung added a commit that referenced this pull request Feb 14, 2024
* refactor: reuse staticFieldInitializerAssignments

* refactor: rename fieldInitializerAssignments to expressions

* test: expand replacement-static-installed-on-correct-class case

* chore: maybePrivateBrandName typo

* wrap version "2023-05" check within Babel 7 branch
nicolo-ribaudo pushed a commit that referenced this pull request Feb 26, 2024
* refactor: reuse staticFieldInitializerAssignments

* refactor: rename fieldInitializerAssignments to expressions

* test: expand replacement-static-installed-on-correct-class case

* chore: maybePrivateBrandName typo

* wrap version "2023-05" check within Babel 7 branch
nicolo-ribaudo pushed a commit that referenced this pull request Feb 27, 2024
* refactor: reuse staticFieldInitializerAssignments

* refactor: rename fieldInitializerAssignments to expressions

* test: expand replacement-static-installed-on-correct-class case

* chore: maybePrivateBrandName typo

* wrap version "2023-05" check within Babel 7 branch
nicolo-ribaudo pushed a commit that referenced this pull request Feb 27, 2024
* refactor: reuse staticFieldInitializerAssignments

* refactor: rename fieldInitializerAssignments to expressions

* test: expand replacement-static-installed-on-correct-class case

* chore: maybePrivateBrandName typo

* wrap version "2023-05" check within Babel 7 branch
liuxingbaoyu pushed a commit to liuxingbaoyu/babel that referenced this pull request Mar 5, 2024
)

* refactor: reuse staticFieldInitializerAssignments

* refactor: rename fieldInitializerAssignments to expressions

* test: expand replacement-static-installed-on-correct-class case

* chore: maybePrivateBrandName typo

* wrap version "2023-05" check within Babel 7 branch
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label May 6, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Internal (next major) 🏠 A type of pull request used for our changelog categories for next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants