New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use updated native GitHub markdown `Note` admonition #16274

Merged

nicolo-ribaudo merged 1 commit into babel:main from yardenshoham:new-note

Feb 11, 2024

Contributor

yardenshoham commented Feb 10, 2024

Follows Use native GitHub markdown Note admonition #15443

GitHub will render it with an icon and color the blockquote. The docs: https://docs.github.com/en/get-started/writing-on-github/getting-started-with-writing-and-formatting-on-github/basic-writing-and-formatting-syntax#alerts

Q	A
Fixed Issues?	None
Patch: Bug Fix?	No
Major: Breaking Change?	No
Minor: New Feature?	No
Tests Added + Pass?	Yes
Documentation PR Link	N/A
Any Dependency Changes?	No
License	MIT

GitHub changed the way they render alerts.

Before

`doc/design/monorepo.md`

`eslint/babel-eslint-plugin-development/README.md`

After

`doc/design/monorepo.md`

`eslint/babel-eslint-plugin-development/README.md`


          [skip ci] Use updated native GitHub markdown Note admonition

93b50ad

- Follows babel#15443

GitHub will render it with an icon and color the blockquote. The docs: https://docs.github.com/en/get-started/writing-on-github/getting-started-with-writing-and-formatting-on-github/basic-writing-and-formatting-syntax#alerts

Signed-off-by: Yarden Shoham <git@yardenshoham.com>

nicolo-ribaudo approved these changes

View reviewed changes

Member

nicolo-ribaudo left a comment

Thanks!

nicolo-ribaudo merged commit 19c54cf into babel:main

1 check passed

yardenshoham deleted the new-note branch

February 11, 2024 09:25

liuxingbaoyu pushed a commit to liuxingbaoyu/babel that referenced this pull request


          Use updated native GitHub markdown Note admonition (babel#16274)

9e94dff

[skip ci] Use updated native GitHub markdown `Note` admonition

- Follows babel#15443

GitHub will render it with an icon and color the blockquote. The docs: https://docs.github.com/en/get-started/writing-on-github/getting-started-with-writing-and-formatting-on-github/basic-writing-and-formatting-syntax#alerts

Signed-off-by: Yarden Shoham <git@yardenshoham.com>

github-actions bot added the outdated label

github-actions bot locked as resolved and limited conversation to collaborators

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.