Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support proposal-explicit-resource-management DisposableStack #16290

Closed
1 task
yf-yang opened this issue Feb 17, 2024 · 3 comments
Closed
1 task

Support proposal-explicit-resource-management DisposableStack #16290

yf-yang opened this issue Feb 17, 2024 · 3 comments
Labels
i: enhancement i: needs triage outdated A closed issue/PR that is archived due to age. Recommended to make a new issue

Comments

@yf-yang
Copy link

yf-yang commented Feb 17, 2024

馃捇

  • Would you like to work on this feature?

What problem are you trying to solve?

@babel/plugin-proposal-explicit-resource-management does not support DisposableStack yet

https://github.com/tc39/proposal-explicit-resource-management#the-disposablestack-and-asyncdisposablestack-container-objects

Describe the solution you'd like

Implement the class.

Describe alternatives you've considered

Nope

Documentation, Adoption, Migration Strategy

No response

@babel-bot
Copy link
Collaborator

Hey @yf-yang! We really appreciate you taking the time to report an issue. The collaborators on this project attempt to help as many people as possible, but we're a limited number of volunteers, so it's possible this won't be addressed swiftly.

If you need any help, or just have general Babel or JavaScript questions, we have a vibrant Slack community that typically always has someone willing to help. You can sign-up here for an invite.

@liuxingbaoyu
Copy link
Member

Have you tried core-js or es-shims, this class should be implemented by polyfills.
It looks like they are already working with babel. (Not tested, just guessing)

@yf-yang
Copy link
Author

yf-yang commented Feb 18, 2024

Yep, core-js works fine, thanks.

core-js should be installed.

[
    "@babel/preset-env",
    {
      ...,
      "useBuiltIns": "usage",
      "corejs": {"version": "3.36", "proposals": true}
    }
  ]

@yf-yang yf-yang closed this as completed Feb 18, 2024
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label May 19, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
i: enhancement i: needs triage outdated A closed issue/PR that is archived due to age. Recommended to make a new issue
Projects
None yet
Development

No branches or pull requests

3 participants