New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: REPL comment for pull request #16297
Conversation
@@ -20,4 +20,4 @@ jobs: | |||
github-token: ${{ secrets.BOT_TOKEN }} | |||
script: | | |||
const { default: repl } = await import('${{ github.workspace }}/scripts/actions/repl.js'); | |||
await repl(); | |||
await repl(github, context); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are not JS variables -- could you move the action to https://github.com/babel/actions and follow how, for example, https://github.com/babel/actions/blob/89fc1d36b649d3b6f2ba40e1051555c999d69842/publish-github-release/main.js#L5 and https://github.com/babel/actions/blob/89fc1d36b649d3b6f2ba40e1051555c999d69842/add-labels/main.js#L9 get these values?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They are defined by actions/github-script
, but if you feel better moving to https://github.com/babel/actions I can do that too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's try to get CI green for now, we can move it to the actions repo later.
Unfortunately it still fails, I will investigate. :) |
This succeeded at #16187 (comment), it looks like it's just failing on the branch in the |
Feel free to create a branch in this repo to test :) |
Fixes #1, Fixes #2
Hopefully it will work. :)