Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: REPL comment for pull request #16297

Merged
merged 1 commit into from Feb 26, 2024
Merged

Conversation

liuxingbaoyu
Copy link
Member

@liuxingbaoyu liuxingbaoyu commented Feb 21, 2024

Q                       A
Fixed Issues? Fixes #1, Fixes #2
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

Hopefully it will work. :)

@@ -20,4 +20,4 @@ jobs:
github-token: ${{ secrets.BOT_TOKEN }}
script: |
const { default: repl } = await import('${{ github.workspace }}/scripts/actions/repl.js');
await repl();
await repl(github, context);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They are defined by actions/github-script, but if you feel better moving to https://github.com/babel/actions I can do that too.
image

Copy link
Member

@nicolo-ribaudo nicolo-ribaudo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's try to get CI green for now, we can move it to the actions repo later.

@nicolo-ribaudo nicolo-ribaudo merged commit 8c3f035 into babel:main Feb 26, 2024
48 of 50 checks passed
@liuxingbaoyu
Copy link
Member Author

Unfortunately it still fails, I will investigate. :)

@liuxingbaoyu
Copy link
Member Author

@nicolo-ribaudo
Copy link
Member

Feel free to create a branch in this repo to test :)

liuxingbaoyu added a commit to liuxingbaoyu/babel that referenced this pull request Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants