Improve @babel/parser AST types
#16425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolo-ribaudo
added
the
PR: Internal 🏠
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/56742 |
nicolo-ribaudo
force-pushed
the
improve-parser-types
branch
from
1de8c37
to
7a056be
Compare
JLHwung
approved these changes
Apr 22, 2024
nicolo-ribaudo
force-pushed
the
improve-parser-types
branch
from
7a056be
to
7455f64
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1, Fixes #2@babel/parser's AST types usedNodeas a base class for every node, effectively making it equivalent to "any" for nodes (since it hadtype: string). This PR replaces it with a proper union of all the possible nodes, like we do in@babel/parser.I was experimenting with merging our type definitions in
@babel/parser, and@babel/types, but it might not be possible because:@babel/parserhas more nodes (ESTree, placeholders)@babel/typeshas node locations as optionalI will still try to add a test to assert that the types are samewhat compatible, in a future PR.