Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Makefile.js fails on Windows #16427

Merged
merged 5 commits into from Apr 18, 2024
Merged

Conversation

liuxingbaoyu
Copy link
Member

@liuxingbaoyu liuxingbaoyu commented Apr 12, 2024

Q                       A
Fixed Issues? Fixes #16426
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

Now we can't execFileSync on yarn.cmd.

@liuxingbaoyu liuxingbaoyu marked this pull request as draft April 12, 2024 23:13
@liuxingbaoyu
Copy link
Member Author

Oh no, there is a problem with this PR.
Error: Attempt to revert an unknown CVE [CVE-2024-x]

This reverts commit 39e160f.
@babel-bot
Copy link
Collaborator

babel-bot commented Apr 12, 2024

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/56721

@liuxingbaoyu
Copy link
Member Author

If I use execa it works, but our bundle script prints Internal error in the corejs3 provider: unknown polyfill "es.array-buffer.detached"..🤦‍♂️

@liuxingbaoyu liuxingbaoyu marked this pull request as ready for review April 12, 2024 23:57
@nicolo-ribaudo nicolo-ribaudo merged commit 610897a into babel:main Apr 18, 2024
51 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Yarn failing on CI on Windows
3 participants