object rest doesn't call Get()

[gsathya]

Input Code

var x = {
  get a() { throw new Error(); },
};

(() => { var { ...y} = x; })();

REPL

Babel Configuration (.babelrc, package.json, cli command)

Presets - ES6- stage3

Expected Behavior

→ ./out.gn/x64.debug/d8 -harmony-object-rest-spread 
V8 version 5.7.0 (candidate)
d8> var x = { get a() { throw new Error(); } };
undefined
d8> (() => { var { ...y } = x; })();
(d8):1: Error
var x = { get a() { throw new Error(); } };
                    ^
Error
    at Object.get a [as a] ((d8):1:27)
    at (d8):1:19
    at (d8):1:30

Current Behavior

No error

Possible Solution

_objectWithoutProperties does not do ? Get(from, nextKey)

[danez]

I just checked the transpiled code of the repl in node 6 and was not able to reproduce. The Error was thrown as expected.

Though it seems the repl is somehow misbehaving here and not evaluating the code correctly.

@gsathya Can you confirm this?

[danez]

Oh I found the issue, it seems the repl is catching the Error and printing it. But as in the example the Error has no msg nothing is printed.

[hzoo]

babel/packages/babel-helpers/src/helpers.js

Lines 430 to 440 in 672adba

	helpers.objectWithoutProperties = template(`
	(function (obj, keys) {
	var target = {};
	for (var i in obj) {
	if (keys.indexOf(i) >= 0) continue;
	if (!Object.prototype.hasOwnProperty.call(obj, i)) continue;
	target[i] = obj[i];
	}
	return target;
	})
	`);

- doesn't handle getters

[danez]

I think it does.

var x = {
  get a() { return 1; },
};

(() => { var { ...y} = x; console.log(y); })();

This code is printing

Object {
  "a": 1
}

And I'm not sure about the specs, but that seems okay, unless the whole getter should be copied over.

[xtuc]

If i'm not wrong this is calling the getter. I wasn't able to reproduce this as well.

[gsathya]

And I'm not sure about the specs, but that seems okay, unless the whole getter should be copied over.

The getter should not be copied over. { "a" : 1 } is correct.

[nicolo-ribaudo]

This works on master: https://babeljs.io/repl/build/master#?babili=false&browsers=chrome%2060&build=&builtIns=false&spec=false&loose=false&code_lz=G4QwTgBAHhC8EG8BQEIHMCmAXCIAUAlIhFgBZgD2A7hAHYY0CiYlYhA3BAL4A0SX7JEixgAnoiQBIPITgA-YqEgIIAOnWiucaJy4EOKXABsMYLHgBEAMRABLIxYKCtAYxBYXpCahAmzlgAUQAGdgx2cgA&debug=false&forceAllTransforms=false&shippedProposals=false&circleciRepo=&evaluate=true&fileSize=false&timeTravel=false&sourceType=module&lineWrap=true&presets=stage-2%2Cenv&prettier=true&targets=Node-6&version=7.3.4