Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

class implements translate err #5626

Closed
zenjava opened this issue Apr 13, 2017 · 5 comments · Fixed by #9897
Closed

class implements translate err #5626

zenjava opened this issue Apr 13, 2017 · 5 comments · Fixed by #9897
Labels
area: flow i: bug outdated A closed issue/PR that is archived due to age. Recommended to make a new issue

Comments

@zenjava
Copy link

zenjava commented Apr 13, 2017

Choose one: is this a bug report or feature request?

Input Code

interface IPCMessager{
   send(): void;
}
class IPC implements IPCMessager {
}

Babel Configuration (.babelrc, package.json, cli command)

"devDependencies": {
     "flow": "^0.2.3",
    "flow-bin": "^0.41.0",
    "flow-webpack-plugin": "^0.3.5",
    "babel-core": "^6.21.0",
    "babel-loader": "^6.2.10",
    "babel-plugin-transform-async-to-generator": "^6.22.0",
    "babel-plugin-transform-flow-comments": "^6.22.0"
}
{
  "plugins": [
    "transform-flow-comments",
    "transform-async-to-generator"
  ]
}

Expected Behavior

translate to

/*:: interface IPCMessager{
  send(): void;
}*/

class IPC  /*implements:: IPCMessager*/ {}

Current Behavior

translate result is

/*:: interface IPCMessager{
  send(): void;
}*/

class IPC implements /*:: IPCMessager*/ {}

Possible Solution

Context

Your Environment

software version(s)
Babel 6.18.0
node 6.9.1
npm 3.10.8
Operating System osx 10.12.4
@babel-bot
Copy link
Collaborator

Hey @zenjava! We really appreciate you taking the time to report an issue. The collaborators
on this project attempt to help as many people as possible, but we're a limited number of volunteers,
so it's possible this won't be addressed swiftly.

If you need any help, or just have general Babel or JavaScript questions, we have a vibrant Slack
community that typically always has someone willing to help. You can sign-up here
for an invite.

@hzoo
Copy link
Member

hzoo commented Apr 13, 2017

Can you follow the issue template? Thanks! I believe you are asking about the flow-comments plugin but not sure.

If you just have an usage issue or want help, I would recommend checking out our slack community or StackOverflow.

@zenjava
Copy link
Author

zenjava commented Apr 13, 2017

Ok ,I have changed the way to the template!

@loganfsmyth
Copy link
Member

I'm curious, have you explored using .js.flow files instead of comments? The transform-flow-comments plugin is definitely buggy.

@zenjava
Copy link
Author

zenjava commented Apr 13, 2017

Yes, I'm used transform-flow-comments plugin.

@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Jul 26, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Jul 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area: flow i: bug outdated A closed issue/PR that is archived due to age. Recommended to make a new issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants