Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(babel-standalone): remove bower mention #6588

Merged
merged 3 commits into from Mar 12, 2018
Merged

Conversation

Haroenv
Copy link
Contributor

@Haroenv Haroenv commented Oct 29, 2017

Since the package won't be downloadable as @babel/standalone it's best to just remove it, since it's pretty much deprecated as is. I left the other mention of babel-standalone-bower since I guess that's just the name and still useful in other cases

cc @Daniel15

reported in #6495 (review)

Q                       A
Fixed Issues? none really
Patch: Bug Fix? no
Major: Breaking Change? no
Minor: New Feature? no
Tests Added + Pass? -
Documentation PR oops, I can't change the commit message now - on GitHub 😢
Any Dependency Changes? no

Since the package won't be downloadable as `@babel/standalone` it's best to just remove it, since it's pretty much deprecated as is. I left the other mention of babel-standalone-bower since I guess that's just the name and still useful in other cases

cc @Daniel15 

reported in babel#6495 (review)
@babel-bot
Copy link
Collaborator

babel-bot commented Oct 29, 2017

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/7214/

@babel-bot
Copy link
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/5528/

Copy link
Member

@xtuc xtuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😄 lgtm

@xtuc
Copy link
Member

xtuc commented Oct 29, 2017

Do we consider this as a breaking change since bowser user won't be able to download it. @Daniel15 do you have any stats about this?

@Haroenv
Copy link
Contributor Author

Haroenv commented Oct 30, 2017

I guess the real breaking change was in #6495 🤔 I can't find bower stats

@nicolo-ribaudo
Copy link
Member

We could keep the babel-standalone bower package with the old name if it is not too confusing.

@Daniel15
Copy link
Member

Daniel15 commented Nov 18, 2017

I don't have any stats, unfortunately.

Installing babel-standalone via Bower pulls it from https://github.com/Daniel15/babel-standalone-bower, which hasn't been updated in a long time (last updated for 6.19.0). I automated it but the automation broke at some point and I never fixed it. Nobody's complained, so I wonder if anyone actually uses it 😛

@Haroenv
Copy link
Contributor Author

Haroenv commented Nov 18, 2017

Exactly. I think that’s why we should remove the mentions of it here!

@danez danez merged commit bdd70c3 into babel:master Mar 12, 2018
aminmarashi pushed a commit to aminmarashi/babel that referenced this pull request Mar 17, 2018
* docs(babel-standalone): remove bower mention

Since the package won't be downloadable as `@babel/standalone` it's best to just remove it, since it's pretty much deprecated as is. I left the other mention of babel-standalone-bower since I guess that's just the name and still useful in other cases

cc @Daniel15 

reported in babel#6495 (review)

* Update README.md
@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 5, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants