New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(babel-standalone): remove bower mention #6588
Conversation
Since the package won't be downloadable as `@babel/standalone` it's best to just remove it, since it's pretty much deprecated as is. I left the other mention of babel-standalone-bower since I guess that's just the name and still useful in other cases cc @Daniel15 reported in babel#6495 (review)
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/7214/ |
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/5528/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😄 lgtm
Do we consider this as a breaking change since bowser user won't be able to download it. @Daniel15 do you have any stats about this? |
I guess the real breaking change was in #6495 🤔 I can't find bower stats |
We could keep the |
I don't have any stats, unfortunately. Installing babel-standalone via Bower pulls it from https://github.com/Daniel15/babel-standalone-bower, which hasn't been updated in a long time (last updated for 6.19.0). I automated it but the automation broke at some point and I never fixed it. Nobody's complained, so I wonder if anyone actually uses it 😛 |
Exactly. I think that’s why we should remove the mentions of it here! |
* docs(babel-standalone): remove bower mention Since the package won't be downloadable as `@babel/standalone` it's best to just remove it, since it's pretty much deprecated as is. I left the other mention of babel-standalone-bower since I guess that's just the name and still useful in other cases cc @Daniel15 reported in babel#6495 (review) * Update README.md
Since the package won't be downloadable as
@babel/standalone
it's best to just remove it, since it's pretty much deprecated as is. I left the other mention of babel-standalone-bower since I guess that's just the name and still useful in other casescc @Daniel15
reported in #6495 (review)