RegExp literal fixes #264
Merged
RegExp literal fixes #264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boopathi
approved these changes
Nov 11, 2016
|
I think we shouldn't bother with "\t" similar to how we don't do this w. Babel literals and minified=true. Does this work with backslash escapes? new RegExp('https?:\\/\\/(?:[\\dA-Za-z\\-]+\\.)+[\\dA-Za-z\\-]+(?::\\d+)?\\/[^\\s]*') |
|
Yeah, that case works I think. |
|
Strange, I'm seeing test failure on travis — https://travis-ci.org/babel/babili/jobs/175548633 — but not locally |
|
Actually, no there's failures locally too. @shinew could you please take a look when you get a chance. |
|
My bad -- forgot to update test after restoring the |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #263.
There's a comment I made in the code about the need to prettify
let a = / /;intolet a = /\t\;, which have the same behavior. This makes the generated literal more clear, at the cost of 1-3 extra characters per invisible newline character when minified. I'm not convinced this beautification is necessary since it's generated code anyway.Thoughts?