Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

minify breaks jquery -> replaces \0 with NUL (Ascii) #732

Closed
jogibear9988 opened this issue Nov 19, 2017 · 3 comments · Fixed by #733
Closed

minify breaks jquery -> replaces \0 with NUL (Ascii) #732

jogibear9988 opened this issue Nov 19, 2017 · 3 comments · Fixed by #733

Comments

@jogibear9988
Copy link
Contributor

Download jquery.min.js from https://code.jquery.com/jquery-3.2.1.min.js

Run Babel Minify on it.

Look at the result File and search for Ascii NUL -> you will find some
@jogibear9988 jogibear9988 mentioned this issue Nov 19, 2017
Closed
@jogibear9988
Copy link
Contributor Author

It also happens if you use the unminified Version of jquery

@jogibear9988
Copy link
Contributor Author

jogibear9988 commented Nov 19, 2017 •
edited

I've now analyzed: if I disable

 babel-plugin-transform-regexp-constructors

it works

@jogibear9988 jogibear9988 mentioned this issue Nov 19, 2017
Merged
@jogibear9988
Copy link
Contributor Author

I've created a fix wich works: #733 but I think, maybe the evaluate() of node Path needs to be fixed?

@jogibear9988 jogibear9988 mentioned this issue Nov 19, 2017
Closed
@jogibear9988 jogibear9988 mentioned this issue Feb 7, 2018
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bugfix Regex's containing (\0) jogibear9988/minify
1 participant
@jogibear9988