Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Meta: breaking changes/codemod TODOs for Babel 7 #30

Closed
hzoo opened this issue Aug 2, 2017 · 8 comments
Closed

Meta: breaking changes/codemod TODOs for Babel 7 #30

hzoo opened this issue Aug 2, 2017 · 8 comments

Comments

@hzoo
Copy link
Member

hzoo commented Aug 2, 2017

We are already pretty swamped with all the work for v7 (and regular work) but I'd be really amazing if the community could help with creating an upgrade tool

So we already have started a guide for updating tool authors: https://github.com/babel/babel.github.io/blob/master/_posts/2017-03-01-upgrade-to-babel-7-for-tool-authors.md / https://babeljs.io/blog/2017/03/01/upgrade-to-babel-7-for-tool-authors (feel free to note and make a PR there too)

I'm just adding a place for people to post issues they've encountered when trying to update that aren't already documented - each of these could be an opportunity to make a codemod (or it's an actual bug)


Example:

file.delete has been removed

power-assert-js/babel-plugin-espower@b887dc3 by @twada

- file.delete('espowerAssertionVisitor');
+ file.set('espowerAssertionVisitor', null);
@hzoo
Copy link
Member Author

hzoo commented Aug 2, 2017

Another PR that breaks plugin API: babel/babel#5923, docs PR babel/website#1286

@hzoo
Copy link
Member Author

hzoo commented Aug 5, 2017

hzoo/gyp.js@a171281 - no changes necessary


cst/cst#164:

  • tokens: true to babylon
  • RestProperty/SpreadProperty -> RestElement/SpreadElement 😢

reduxjs/redux#2550 no changes needed

@hzoo
Copy link
Member Author

hzoo commented Aug 29, 2017

styled-components/babel-plugin-styled-components#84
file.opts.filename instead of file.opts.basename

@xtuc
Copy link
Member

xtuc commented Aug 29, 2017

We need to add them to the breaking changes documented in the blog post. I'll try today if I have some time.

twada added a commit to power-assert-js/babel-plugin-espower that referenced this issue Oct 11, 2017
@twada
Copy link

twada commented Oct 25, 2017

power-assert-js/babel-plugin-espower@89a9d7e
file.opts.parserOpts instead of file.parserOpts

@twada
Copy link

twada commented Oct 25, 2017

power-assert-js/babel-plugin-espower@ff72e23
use file.inputMap to handle incoming sourcemaps (file.opts.inputSourceMap has gone away)

@hzoo
Copy link
Member Author

hzoo commented Apr 4, 2018

@babel-bot move to babel/babel-upgrade

@hzoo
Copy link
Member Author

hzoo commented Apr 4, 2018

Moving to babel/babel-upgrade#59

@hzoo hzoo closed this as completed Apr 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants