New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TODO #2
Comments
I updated the comment a little bit and added more stuff. In general I think it would be good to "calculate" all the necessary changes to be made to github in the first task, and then as quickly as possible (github api probably has throttling) execute the changes. |
Just wanted to mention that it's probably not worth logging these issues yourself because that data can be queried easily from the issues search. You could find them by searching with a query that uses a range filter on the created timestamp (using the start and end timestamps of the migration script) and excludes all issues filed by the bot user. For example:
|
Thanks, that is even easier. |
Ok I contacted github - we should try using the (unfinished) API described in https://gist.github.com/jonmagic/5282384165e0f86ef105 to get around some of the issues we mentioned above |
for attachments we can link to the issue instead? I wonder how many of those there are anyway we can move the parser issues manually too |
Just an issue to track what we can/should do to migrate
Info
Old issue id range:
1 - 3086
(maniphest_task)New issue range:
> 6637
Number of new issues:
~871
Number of new comments:
~2940
Github ratelimit is 5000 requests/hour (https://developer.github.com/v3/#rate-limiting)
Open questions:
How to compare/merge issues? Someone needs to check if the github id is somewhere in the phabricator dump. Otherwise we need to retrieve all comments beforehand.Phabricator ids match the github ids.Do we want to migrate issues that do not exist yet in github but are already closed?YESTasks:
handle the edge case that someone really posts an issue during migration and log these issue numbers (should be easy by just looking if the returned issue number from the api is +1 the last issue number), otherwise they might get lost in the flood of issues.babel-bot
)The text was updated successfully, but these errors were encountered: