Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move site to Netlify? #1289

Closed
Daniel15 opened this issue Aug 5, 2017 · 4 comments
Closed

Move site to Netlify? #1289

Daniel15 opened this issue Aug 5, 2017 · 4 comments

Comments

@Daniel15
Copy link
Member

Daniel15 commented Aug 5, 2017

This would allow us to add custom build steps, which is needed if we want to compile JavaScript on the site itself using Babel (for example, to convert the REPL into a React component #1287).

I created a Babel site on Netlify as a proof-of-concept: https://babel.netlify.com/. This is basically the same as the current site, running jekyll build to build it. We'd just need to point the babeljs.io domain to Netlify to move across. As a bonus, we could get proper end-to-end SSL rather than the CloudFlare one that's unencrypted from CloudFlare to the origin.

@Daniel15
Copy link
Member Author

Daniel15 commented Aug 5, 2017

The other advantage of Netlify is that it builds a preview version of the website for each pull request

Example PR: https://github.com/Daniel15/babel-site/pull/2/files
Preview for that PR: https://deploy-preview-2--babel.netlify.com/

@hzoo
Copy link
Member

hzoo commented Aug 6, 2017

Ok that's really cool too!

  • https
  • faster?
  • PR build
  • build step

all sounds good to me?

cc @thejameskyle on the domain?

@Daniel15
Copy link
Member Author

Daniel15 commented Aug 6, 2017

This is ready to go, just need to get the DNS updated.

Netlify is so fast... It's building pull requests in around 55 seconds. In the time it takes for Travis to simply spin up the environment (install Node.js, Rubygems, and npm packages), Netlify has already built and deployed the preview site.

@Daniel15 Daniel15 assigned jamiebuilds and unassigned jamiebuilds Aug 7, 2017
@Daniel15
Copy link
Member Author

Daniel15 commented Aug 8, 2017

Done! Feel free to ping me directly if you notice any brokenness.

@Daniel15 Daniel15 closed this as completed Aug 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants