Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maven-assembly-plugin does not use source or target in its configuration #14

Merged

Conversation

brtrvn
Copy link
Contributor

@brtrvn brtrvn commented Oct 28, 2021

Description

Remove incompatible and tags from the maven-assembly-plugin configuration

Issues Resolved

Resolves issue #13

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is under the terms of the Apache 2.0 license.

For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@robverschoor
Copy link
Collaborator

ran checks - all OK

@brtrvn
Copy link
Contributor Author

brtrvn commented Nov 1, 2021

You approved this pull request and then closed it without merging it. I'm confused.

@robverschoor
Copy link
Collaborator

robverschoor commented Nov 1, 2021 via email

@zli236 zli236 reopened this Nov 1, 2021
@zli236 zli236 self-requested a review November 1, 2021 19:56
@robverschoor robverschoor merged commit fbcda6c into babelfish-for-postgresql:main Nov 1, 2021
@brtrvn brtrvn deleted the assembly-plugin-fix branch November 2, 2021 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants