websocket demo issue

[mmardinian]

Hi,

I am interested in the websocket demo. The demo works with Firefox but it doesn't work with Chrome.
When the websocket connection request is sent, the websocket is created and then directly deleted.

Also, there is an issue with string handling.

• The user data "my_user_data" has its 4 first bytes overwrited when passed to the websocket engine.
• And string messages coming from the websocket client don't reach the incoming messages callback on the server.

Please let me know if I can support you.
Best regards,
Michael

[babelouest]

Hello,

Thanks for the bug report. Indeed the websocket example doesn't work for me too in Chrom[e|ium] browser and I don't know why yet, this looks very weird though. I found a related bug in Orcania. But this doesn't fix the websocket problem in Chrome yet.

Concerning the string handling issue, can you be more specific? I've retested the example using valgrind and nothing popped for valgrind, the memory was clean. If you confirm this memory problem, can you open a new issue in github?

Thanks for your help!

[babelouest]

Hello again,

I think I solved the problem on the websocket_example. Can you check the branch fix-websockets and tell me if the problem is fixed on your side? It's not complete yet because I've seen I'm not fully RFC compliant but this will be addressed soon.

[mmardinian]

I checked out the branch but on my side it's worth.
It stills not work on chrome, and and doesn't work anymore on firefox... :/

[babelouest]

did you update orcania too? The branch fix-websockets in Ulfius is now plugged with the orcania branch fix-string_array_has_trimmed_value

[mmardinian]

I had not the first time.
I did now but it didn't change a thing.
Neither Chrome or Firefox works for me now

[babelouest]

When you open the browser console (F12), what does the error say?

[mmardinian]

For firefox:

WebSocket
binaryType: "blob"
bufferedAmount: 0
extensions: ""
onclose: function connectSocket/mySocket.onclose()
onerror: null
onmessage: function connectSocket/mySocket.onmessage()
onopen: null
protocol: ""
readyState: 3
url: "ws://10.0.164.36:9275/websocket"
proto: WebSocketPrototype { close: close(), send: send(), url: Getter, … }
index.html:37:4
Firefox ne peut établir de connexion avec le serveur à l’adresse ws://10.0.164.36:9275/websocket.

[babelouest]

What does the connection says in the network tab?

[mmardinian]

*** Error im './websocket_example': double free or corruption (fasttop): 0x75300cf8 ***
Aborted (core dumped)

[babelouest]

I've pushed some more in the fix-websocket branch, including a change in Orcania. I was able to make the websocket work on my side.
I was able to run the websocket_example on Ubuntu 17.10 (amd64) with Firefox and Chromium, and also on a solid Raspberry Pi 2 running Raspbian Stretch.

Can you re-run your tests with this new code?

[mmardinian]

Thanks that works now for both Chrome and Firefox.
Great support ;-)

[mmardinian]

Could you please let me know when you will merge this corrective branch into the master?

[babelouest]

That's an excellent news!
It will be merged soon, probably today.