Unable to set refresh_documents in phpunit.xml due to strict bool checking

[stevebauman]

Software	Version
PHP	8.0
Elasticsearch	7.*
Laravel	9.*
Laravel Scout	9.*

Describe the bug
Due to:

elastic-scout-driver/src/Engine.php

Line 38 in 9b15115

$this->refreshDocuments = config('elastic.scout_driver.refresh_documents');

And:

https://github.com/babenkoivan/elastic-adapter/blob/50e9559774c09688a0f5024c964ab22b97c554de/src/Documents/DocumentManager.php#L22

We can't supply a "truthy" value to refresh_documents in our phpunit.xml:

<!-- ... -->
<php>
    <env name="ELASTIC_SCOUT_DRIVER_REFRESH_DOCUMENTS" value="1"/>
    <!-- ... -->
</php>

An exception is thrown:

TypeError: ElasticAdapter\Documents\DocumentManager::index(): Argument #3 ($refresh) must be of type bool, string given

To Reproduce

1. Publish the configuration file
2. Add <env name="ELASTIC_SCOUT_DRIVER_REFRESH_DOCUMENTS" value="1"/> to your phpunit.xml
3. Run a test

Expected behavior
We should cast the value to a boolean before passing it to the DocumentManager.

[babenkoivan]

Hey @stevebauman, thanks for pointing this out. The issue should be fixed in v3.0.1 🙂

[stevebauman]

Excellent, thanks @babenkoivan! 😄