Skip to content
This repository has been archived by the owner on Apr 19, 2021. It is now read-only.

Hot reloading (automatic refreshing) from TypeScript files #9

Open
babichjacob opened this issue Jul 10, 2020 · 2 comments
Open

Hot reloading (automatic refreshing) from TypeScript files #9

babichjacob opened this issue Jul 10, 2020 · 2 comments
Labels
enhancement New feature or request upstream This can only be solved by an upstream project's changes

Comments

@babichjacob
Copy link
Owner

From Carlo$#3952 on Discord

My issue is this:

//client.ts
import * as sapper from "@sapper/app";
import { setup } from "fileInSRCNodeModules";

(async () => {
  await setup();
  await sapper.start({
    target: document.querySelector("#sapper")
  });
)();

When I run

npm run dev

I get:

Could not load C:/example/src/node_modules/fileInSRCNodeModules.ts (imported by C:\example\src\client.ts): Debug Failure. False expression: Expected fileName 
to be present in command line

Edit 1:
Creating the file in "/src/someFile.ts" or even "/src/folder/someFile.ts"
And then calling it from "client.ts" as -

import { setup } from "./someFile.ts"

works

am I accidently not allowing "node_modules" access? But "@sapper/app" works

@babichjacob babichjacob self-assigned this Jul 10, 2020
@babichjacob babichjacob added bug Something isn't working question Further information is requested labels Jul 10, 2020
@babichjacob
Copy link
Owner Author

babichjacob commented Jul 11, 2020

Live reload possibly not working
Probably an upstream problem

@babichjacob babichjacob added upstream This can only be solved by an upstream project's changes and removed question Further information is requested labels Jul 11, 2020
@babichjacob babichjacob changed the title Accessing TypeScript files from src/node_modules/ TypeScript files in src/node_modules/; Hot reloading (automatic refreshing) from TypeScript files Jul 11, 2020
@babichjacob
Copy link
Owner Author

I manually added livereload: import livereload from "rollup-plugin-livereload"; to rollup.config and set it the config to dev && livereload("sapper/dev"),
This allows the hot reload off of any rebuilds - however - since sapper already rebuilds by default on all changes but .ts files - this causes the reload to happen twice on files except .ts
So - Iooked through the sapper cli and you can set the reload to false
I modified the npm run dev to be: "dev": "cross-env ROLLUP_WATCH=true sapper dev --live false",
Now, it rebuilds accordingly

image

@babichjacob babichjacob removed their assignment Jul 22, 2020
@babichjacob babichjacob added enhancement New feature or request and removed bug Something isn't working labels Aug 8, 2020
@babichjacob babichjacob changed the title TypeScript files in src/node_modules/; Hot reloading (automatic refreshing) from TypeScript files Hot reloading (automatic refreshing) from TypeScript files Aug 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request upstream This can only be solved by an upstream project's changes
Projects
None yet
Development

No branches or pull requests

1 participant