Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JoSS Review: Performance #12

Closed
ghost opened this issue Jan 29, 2020 · 2 comments
Closed

JoSS Review: Performance #12

ghost opened this issue Jan 29, 2020 · 2 comments

Comments

@ghost
Copy link

ghost commented Jan 29, 2020

In conjunction with the review of your package to JoSS (available at openjournals/joss-reviews#2014), here is an issue for you to address for your submission.

In your paper, you have stated that one of the advantages of recan over other methods of recombination detection (e.g. RAT and RDP4) is speed. However, I do not think the speed of recan should be compared to that of the aforementioned programs as the recombination auto-search function (which consumes a lot of run-time and is the main focus of RAT and RDP4) has not been implemented in recan.

@babinyurii
Copy link
Owner

Thank you for valuable comment, @lamhm. I agree with you, the speed comparison was incorrect. Now the paper was edited, and that statement was deleted.

@ghost
Copy link
Author

ghost commented Mar 3, 2020

Thanks a lot, @babinyurii. I confirm that the performance statement has been corrected in the paper. I will close this issue now.

@ghost ghost closed this as completed Mar 3, 2020
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant