Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lag While Closing #20

Closed
babluboy opened this issue Feb 26, 2017 · 4 comments
Closed

Lag While Closing #20

babluboy opened this issue Feb 26, 2017 · 4 comments
Assignees
Milestone

Comments

@babluboy
Copy link
Owner

There is a lag while Bookworm is closing as the state of each book in the library is saved to database. This lag increases when the number of books in the library is more.

Fix the issue so that the window is closed quickly and the process for saving the state of the books is done in the background

@babluboy babluboy added the Bug label Feb 26, 2017
@babluboy babluboy added this to the 0.3 milestone Feb 26, 2017
@babluboy babluboy self-assigned this Feb 26, 2017
@Philip-Scott
Copy link

Or only save the state of the book you are reading. You might be doing extra unnecessary writes ;)

@babluboy
Copy link
Owner Author

@Philip-Scott Thats a good thought, at the moment I'm updating all the books data into the DB, irrespective of whether the user opened it or not. So definite scope for improvement.
However, using the async with callback I have managed to run the DB update without blocking the window closure. Done a few tests with around 30 books in the library and works fine, so closing this issue.

@babluboy
Copy link
Owner Author

@choyan Marking you for this issue, hoping that you have some more ePubs to test this issue with around 50+ books when you have some time. Key sucess criteria:
1- When you close Bookworm, it should close immediately without lag
2- When you open Bookworm again, it should have "remembered" the last page of all the books which you would have opened in the last session and open those books from the correct page

@babluboy babluboy modified the milestones: 0.2, 0.3 Feb 26, 2017
@choyan
Copy link
Contributor

choyan commented Feb 27, 2017

@babluboy I've checked with more 60 books in the library. And opened several books.
1- The app is closing instantly without lag.
2- The database is working fine and saving the book state properly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants