Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grab App Token "DNR"s #27

Closed
MrApplejuice opened this issue May 7, 2023 · 2 comments
Closed

Grab App Token "DNR"s #27

MrApplejuice opened this issue May 7, 2023 · 2 comments
Assignees
Labels
app-store Changed required for the app-store presence bug Something isn't working
Milestone

Comments

@MrApplejuice
Copy link
Collaborator

The app forces a synchronous check on app-token availability which goes against Android design guidelines in the first place, but was done to be able to release the app more quickly.

This used to only cause "DNR"s which do not look good but are not critical per-se. However, when the network connection becomes slow, this also can cause hard crashes when Android terminates the app due to timeouts.

This should be fixed in the next release as well!

@MrApplejuice MrApplejuice added bug Something isn't working app-store Changed required for the app-store presence labels May 7, 2023
@MrApplejuice MrApplejuice added this to the 1.3.0 milestone May 7, 2023
@MrApplejuice MrApplejuice modified the milestones: 2.0.0, Next release May 24, 2023
@MrApplejuice MrApplejuice self-assigned this May 26, 2023
@MrApplejuice
Copy link
Collaborator Author

Causes actual crashes. This needs to be fixed soon!

      at java.lang.Object.wait (Native method)
      at java.lang.Object.wait (Object.java:442)
      at java.lang.Thread.join (Thread.java:1432)
      at java.lang.Thread.join (Thread.java:1513)
      at eu.pkgsoftware.babybuddywidgets.networking.GrabAppToken.grabToken (GrabAppToken.java:90)
      at eu.pkgsoftware.babybuddywidgets.LoginFragment.performLogin (LoginFragment.java:257)
      at eu.pkgsoftware.babybuddywidgets.LoginFragment.lambda$uiStartLogin$5$eu-pkgsoftware-babybuddywidgets-LoginFragment (LoginFragment.java:179)
      at eu.pkgsoftware.babybuddywidgets.LoginFragment$$ExternalSyntheticLambda4.onClick (D8$$SyntheticClass)
      at com.android.internal.app.AlertController$ButtonHandler.handleMessage (AlertController.java:235)
      at android.os.Handler.dispatchMessage (Handler.java:110)
      at android.os.Looper.loop (Looper.java:219)
      at android.app.ActivityThread.main (ActivityThread.java:8668)  
      at java.lang.reflect.Method.invoke (Native method)
      at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run (RuntimeInit.java:513)
      at com.android.internal.os.ZygoteInit.main (ZygoteInit.java:1109)

@MrApplejuice
Copy link
Collaborator Author

Code is async now. It should work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app-store Changed required for the app-store presence bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant