Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fixtures and improve tests #18

Closed
cdubz opened this issue Nov 11, 2017 · 4 comments
Closed

Add fixtures and improve tests #18

cdubz opened this issue Nov 11, 2017 · 4 comments

Comments

@cdubz
Copy link
Member

cdubz commented Nov 11, 2017

Tests are a bit weak right now, fixtures will likely help to write more specific and useful tests in a lot of situations (instead of relying the fake data generation).

Tangentially related, the fake command could be refactored to generate more realistic data - right now entries with duration intersect and make little sense (e.g. feedings while baby is asleep).

@cdubz
Copy link
Member Author

cdubz commented Nov 11, 2017

5dec231 greatly improves the quality (and speed!) of the fake command. This should improve some testing on its own, but will also help to create better test fixtures.

@cdubz
Copy link
Member Author

cdubz commented Nov 11, 2017

Oops. Need to re-add the random color choice when Diaper Chabge is “solid” in _add_diaperchabge_entry

@cdubz
Copy link
Member Author

cdubz commented Nov 19, 2017

Random solid colors fixed in 4aa51e4. On to fixtures...

@cdubz
Copy link
Member Author

cdubz commented Nov 19, 2017

452ce19 adds Dashboard card tests using fixtures.

@cdubz cdubz closed this as completed Dec 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant