Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not attempt to deploy demo on PRs in CI #339

Closed
cdubz opened this issue Nov 16, 2021 · 1 comment
Closed

Do not attempt to deploy demo on PRs in CI #339

cdubz opened this issue Nov 16, 2021 · 1 comment
Labels
task Specific non-feature things to do that don't require debugging

Comments

@cdubz
Copy link
Member

cdubz commented Nov 16, 2021

The CI YAML needs to be updated somehow to prevent it from attempting to deploy the demo to Heroku on PRs. I thought the current config would do that but apparently it does not...
@cdubz cdubz added the task Specific non-feature things to do that don't require debugging label Nov 16, 2021
@cdubz cdubz changed the title Fix demo deploy to not attempt on PRs Fix demo deploy action to not attempt on PRs Nov 16, 2021
@cdubz cdubz changed the title Fix demo deploy action to not attempt on PRs Do not attempt to deploy demo on PRs in CI Nov 16, 2021
@cdubz
Copy link
Member Author

cdubz commented Nov 20, 2021

Fixed by 2fea4c8

@cdubz cdubz closed this as completed Nov 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
task Specific non-feature things to do that don't require debugging
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cdubz