Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle plurals with count tag of blocktrans #472

Closed
amorphobia opened this issue Jun 4, 2022 · 2 comments
Closed

Handle plurals with count tag of blocktrans #472

amorphobia opened this issue Jun 4, 2022 · 2 comments
Labels
i18n/L10n Issues relating to internationalization and/or localization

Comments

@amorphobia
Copy link
Contributor

amorphobia commented Jun 4, 2022

Currently, several plurals are generated with pluralize filter. I found it wired when translating to Chinese.

Usually, nouns do not have plural forms in Chinese, and the %(plural)s term will append an extra "s". However, if I delete %(plural)s in the msgstr, it would not pass the checker and leave original English message there.

Instead, if count tag is used, it can be solved by only translate msgstr[0]. I made a commit in my forked repo. But this may break all other translations, so I did not open new PR. If you think it make sense, I will open one.

@cdubz
Copy link
Member

cdubz commented Jun 5, 2022

Interesting -- I didn't know about the count tag. This does look like a better solution and I'd take PR for it. Breaking other translations is unfortunate but I think it's worth using this as a better approach anyway.

@cdubz cdubz added the i18n/L10n Issues relating to internationalization and/or localization label Jun 5, 2022
@cdubz
Copy link
Member

cdubz commented Jun 5, 2022

#473 is merged. Thanks for contributing!

@cdubz cdubz closed this as completed Jun 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
i18n/L10n Issues relating to internationalization and/or localization
Projects
None yet
Development

No branches or pull requests

2 participants