Issue with Tummy time graph bar

[Anoerak]

There is an issue on the Tummy time graph bar report where session above an hour are shown for only the minutes past the hours (1h10min becomes 10min) in the bar legend.
e.g. screenshots

[Anoerak]

Hi,
Issue's coming from file 'tummytime_duration.py', line 73:
return "{}m{}s".format(m, s)
Missing hours here ao should be:
return "{}h{}m{}s".format(h, m, s)

I'm not familiar with open source code and team work (newbie in development, actually following a course on JS & React aftter graduating in web development last year).
So if I can help in a more efficient way, I'm all ears :).

[cdubz]

Nice catch. Here is where you found the issue:

babybuddy/reports/graphs/tummytime_duration.py

Lines 66 to 73 in cba4a2b

	def _duration_string_ms(duration):
	"""
	Format a "short" duration string with only minutes and seconds. This is
	intended to fit better in smaller spaces on a graph.
	:returns: a string of the form Xm.
	"""
	h, m, s = duration_parts(duration)
	return "{}m{}s".format(m, s)

It would seem this was intentional to save space and because tummy time generally is not expected to be that long. I think an ideal solution here would be to add support for hours but only display it if necessary. E.g., we don't want 0h10m30s for a 10 minute, 30 seconds entry.

I'm not familiar with open source code and team work (newbie in development, actually following a course on JS & React aftter graduating in web development last year).
So if I can help in a more efficient way, I'm all ears :).

Well reporting an issue is an important first step 😄 The next thing we'd want here is pull request to fix the issue. The basic steps to do so would be:

• Fork the repository.
• Make the necessary changes in your fork.
• Open a PR against master with your fork.

Let me know if you want to give this a try. Even with limited Python experience this one should be pretty straight forward.

[Anoerak]

OK, thanks.
I wrote a condition to display hour when needed and created a PR.
Let me know if I did right or wrong :)

edit: the Dokku test is failing and have no idea why.

[cdubz]

@Anoerak haha yeah sorry about the Dokku test -- don't worry about it. Just something I am trying to get working but haven't yet 😄

#561 resolves this and is merged. Thank you!!