Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nap field always False when adding Sleep entries via API #657

Closed
Cadair opened this issue Jun 5, 2023 · 6 comments
Closed

Nap field always False when adding Sleep entries via API #657

Cadair opened this issue Jun 5, 2023 · 6 comments
Labels
bug Reports of unexpected problems or errors
Milestone

Comments

@Cadair
Copy link

Cadair commented Jun 5, 2023

I haven't had a chance to look at this yet, but I updated to beta2 today and now all the sleep entries are showing as not naps despite the site wide settings.

It was working well on beta1

@cdubz
Copy link
Member

cdubz commented Jun 5, 2023

Argh OK. Thanks for sharing. I can't repro at the moment in the demo so will appreciate if you can share more about your configuration.

@cdubz cdubz added bug Reports of unexpected problems or errors need more info Needs more information from issue poster labels Jun 5, 2023
@Cadair
Copy link
Author

Cadair commented Jun 6, 2023

I still haven't looked properly at a PC, but it seems that when entering a sleep in the web ui the nap toggle is correctly pre-populated. However, when i enter a sleep from home assistant via the api it is always not-a-nap.

@cdubz
Copy link
Member

cdubz commented Jun 6, 2023

Ok that’s helpful context. Will try to do some testing with that information.

To be clear do you mean that the nap feature is not working for new naps? So existing naps in the system are still correct?

@Cadair
Copy link
Author

Cadair commented Jun 7, 2023

Yeah it seems that all the historical data is fine.

@cdubz
Copy link
Member

cdubz commented Jun 14, 2023

FTR I have at least confirmed this. The API always defaults to False and does not respect the nap boundaries. Haven’t had a chance yet to dig in to potential solutions though.

@cdubz cdubz removed the need more info Needs more information from issue poster label Jun 14, 2023
@cdubz cdubz changed the title 2.0.0beta2: Nap times appear broken? Nap fields always False when adding Sleep entries via API Jun 14, 2023
@cdubz cdubz changed the title Nap fields always False when adding Sleep entries via API Nap field always False when adding Sleep entries via API Jun 14, 2023
@cdubz cdubz closed this as completed in 759bbe9 Jun 15, 2023
@cdubz cdubz added this to the 2.0.0-beta3 milestone Jun 15, 2023
@Cadair
Copy link
Author

Cadair commented Jun 15, 2023

Thanks! Looks like it's working as intended for us 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Reports of unexpected problems or errors
Projects
None yet
Development

No branches or pull requests

2 participants