Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some reports have end date +1 week in the future #706

Closed
MisterPhilip opened this issue Sep 14, 2023 · 2 comments
Closed

Some reports have end date +1 week in the future #706

MisterPhilip opened this issue Sep 14, 2023 · 2 comments
Labels
bug Reports of unexpected problems or errors third party Relies on or blocked by a third party (dependency, vendor, platform, etc.)
Milestone

Comments

@MisterPhilip
Copy link
Contributor

Since upgrading to v2.x.x, I noticed that a couple of the graph's automatic date x-axis uses a future date. Thus, when you switch to a shorter time frame (e.g., 1 week, 2 weeks) you are potentially missing a lot of data.

This seems to only happen on Average Feeding Duration and Diaper Change Types reports, but we also aren't using all of the reports so it could be happening on others. Other reports we use (Feeding Amounts, Sleep Totals, and Sleep Pattern) show the correct last date.

image
image

Neither of these have an accidental log in the future, and the JS returned does show the correct date for the latest entry.
image
image

I suspect this is a ploty issue as I was able to replicate it with the JS version with the same data points. Interestingly, if I remove some of the data points (any of them), it renders the x-axis correctly. It might be a limit to the number of plots before autorange freaks out? Anyways, manually setting the range and disabling autorange seems to fix the issue. I'm not sure it is worth the trouble to change the graph configs for Baby Buddy but thought I'd log the bug anyways!

@cdubz
Copy link
Member

cdubz commented Sep 19, 2023

Hmmm weird. In your codepen if I set autorange to false it does indeed work better on the initial view but I still see the extra dates e.g. if I click "1w", then "all", then "1w" again...

@cdubz cdubz added bug Reports of unexpected problems or errors third party Relies on or blocked by a third party (dependency, vendor, platform, etc.) labels Sep 27, 2023
@cdubz
Copy link
Member

cdubz commented Jan 27, 2024

@cdubz cdubz closed this as completed in c1e4876 Jan 28, 2024
@cdubz cdubz added this to the 2.2.1 milestone Jan 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Reports of unexpected problems or errors third party Relies on or blocked by a third party (dependency, vendor, platform, etc.)
Projects
None yet
Development

No branches or pull requests

2 participants