Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CornerRadius only affecting border, not drawer itself #67

Closed
Umar-M-Haroon opened this issue May 15, 2018 · 3 comments
Closed

CornerRadius only affecting border, not drawer itself #67

Umar-M-Haroon opened this issue May 15, 2018 · 3 comments
Assignees
@wltrup
Labels
bug question

Comments

@Umar-M-Haroon
Copy link

I'm playing with the demo app and the corner radius doesn't seem to be affecting the actual VC itself. This is how it looks in the simulator on 11.3 Xcode 9.3.1. Border is there, but it wont affect the drawer itself. Am I missing something?
image
@timersha
Copy link

timersha commented Jul 9, 2018

@Umar-M-Haroon, I have the same issue, have you fixed this behavior?

@Umar-M-Haroon
Copy link
Author

Nope unfortunately I couldn't figure out how to fix this 😞

@wltrup wltrup mentioned this issue Jul 13, 2018
Merged
@wltrup wltrup added the bug label Jul 13, 2018
@wltrup
Copy link
Contributor

wltrup commented Jul 13, 2018

Hi @Umar-M-Haroon, thanks for your interest in DrawerKit and for reporting a bug!

The bug has now been fixed. See this PR for details.

Once again, many thanks!

@wltrup wltrup closed this as completed Jul 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wltrup wltrup

Labels
bug question
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@RuiAAPeres @wltrup @Umar-M-Haroon @timersha