Support interactions on presenting view #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilyapuchka
force-pushed
the
interactive-presenting-view
branch
from
f98d008
to
bd8cf71
Compare
ilyapuchka
force-pushed
the
interactive-presenting-view
branch
from
bd8cf71
to
92b5013
Compare
wltrup
suggested changes
Oct 25, 2018
| @@ -79,6 +79,35 @@ class DrawerKitDemoUITests: XCTestCase { | |||
| XCTAssertFalse(isDrawerOpen()) | |||
| XCTAssertFalse(isDrawerFullyOpen()) | |||
| } | |||
|
|
|||
| func testTouchesPassthrough() { | |||
| let mainCanvase = app.buttons[Identifiers.mainCanvas] | |||
wltrup
previously approved these changes
Oct 25, 2018
wltrup
previously requested changes
Oct 25, 2018
wltrup
suggested changes
Oct 25, 2018
DrawerKit/DrawerKit/Internal API/PresentationController+Setup.swift
Outdated
Show resolved
Hide resolved
DrawerKit/DrawerKit/Internal API/PresentationController+Setup.swift
Outdated
Show resolved
Hide resolved
…swift Co-Authored-By: ilyapuchka <ilyapuchka@gmail.com>
…swift Co-Authored-By: ilyapuchka <ilyapuchka@gmail.com>
wltrup
approved these changes
Oct 25, 2018
wltrup
previously requested changes
Oct 25, 2018
ilyapuchka
force-pushed
the
interactive-presenting-view
branch
from
2fd88f1
to
dd20c07
Compare
wltrup
previously approved these changes
Oct 26, 2018
|
I've approved, under the assumption that you'll fix the broken tests. |
wltrup
previously approved these changes
Oct 26, 2018
ilyapuchka
force-pushed
the
interactive-presenting-view
branch
5 times, most recently
from
dba0c85
to
77744ea
Compare
ilyapuchka
force-pushed
the
interactive-presenting-view
branch
11 times, most recently
from
619064f
to
2245929
Compare
ilyapuchka
force-pushed
the
interactive-presenting-view
branch
from
2245929
to
52de547
Compare
|
|
ilyapuchka
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the presented view is not responding to touches when drawer view is presented because it appears behind
UITransitionViewadded by UIKit, which intercepts all the touches.One option to allow interactions of presented view could be to add its view as subview of
transitionContext.containerViewbut that will make it to collide with tap recogniser and can result to unexpected behaviour when dismissing drawer with tap (if drawer is attempted to be presented twice then after it is dismissed UIKit does not call presentation controller methods)Instead we put container view inside a subclass of
UIViewthat implementshitTestand delegates it to presentation controller to decide what view, presented or container view should receive touches.The gif shows that the view on background is accessible in partial expanded state but not in full screen, which can be configured.