Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

An unnecessary trace log is output in the latest version of Spector.js #38

Closed
cx20 opened this issue May 27, 2017 · 4 comments
Closed

Comments

@cx20
Copy link

cx20 commented May 27, 2017

I discovered that unnecessary trace logs will appear in the latest version of Spector.js.
Relate: #35

OS / Browser : Windows 10 + Chrome 58 + Spector.js v0.2.1

How to reproduce the problem:

  1. Install Spector.js from the Chrome Web Store.
    https://chrome.google.com/webstore/detail/spectorjs/denbgaamihkadbghdceggmchnflmhpmk
  2. Please access the WebGL sample page with Chrome.
  3. Start the Spector.js extension from the toolbar.
    image
    Unnecessary trace log (glp -> [object Object]) seems to be outputted.
    image
@sebavan
Copy link
Member

sebavan commented May 28, 2017

Seems to be linked to the fact that other extensions are also tracking the context (probably weblglinsight) I need to figure out how to split between the real log and the other extensions commands.

@cx20
Copy link
Author

cx20 commented May 28, 2017

I confirmed that the path output to Stack Trace matches the ID of WebGL Insight.

Stack Trace
0: WebGLRenderingContext.default (chrome-extension://djdcbmfacaaocoomokenoalbomllhnko/src/content_script/fcn_bindings.js:7:12)
1: WebGLRenderingContext.drawElements (chrome-extension://djdcbmfacaaocoomokenoalbomllhnko/src/content_script/webgl_bind.js:10:24)
2: WebGLRenderingContext.drawElements (<anonymous>:1:96314)
3: h.draw (http://jsrun.it/assets/3/W/f/g/3WfgZ:4:8704)

image

I tried to disable the "WebGL Insight" Chrome extension, and unnecessary trace logs are no longer output.

@sebavan
Copy link
Member

sebavan commented Jun 10, 2017

@cx20 I am still trying to figure the best approach concerning this issue.

@sebavan
Copy link
Member

sebavan commented Jun 13, 2017

Explicitly removed those internals commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants