-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build on Windows machine #7
Comments
for M_PI is not defined: And this line can't be compiled with MSVC. variadic macro here is non-standard. replace args VA_ARGS here to resolve error. Line 3 in ba37316
|
Thanks for the report! |
@BachiLi I am still working on it. |
@tim37021 I also fail to import redner.dll into python3.6 in conda environment, in the same situation with yours. "ImportError: DLL load failed: The specified module could not be found." is reported by python. |
I think it has to do with the fact that I did not link the Python libraries while building. This can cause problems on windows. For now you can try adding ${Python_LIBRARIES} in target_link_libraries() and see if it works. I'll take a look once I get a windows machine. |
@swordigo1995 other dependencies dlls(embree3.dll, tbb.dll, tbb_malloc.dll) are also missed when importing redner. @BachiLi btw, I've successfully built and tested on linux |
@tim37021 @BachiLi Thanks a lot for your advice!! 👍
|
@swordigo1995 I switched to linux quickly when I've failed on windows. On linux some modifications are still necessary to get it work. And you need to build pytorch on your own for using CUDA 10. |
Would be great to have a windows build working.. Not sure why windows always get the short shrift. Lots of ML practitioners still use windows, particularly those from a graphics background. |
Check out #11 |
Just FYI, I'm currently working on Windows compatibility. I added prebuild windows binaries to the dependencies, adapted the imports of embree and optix and implemented MSVC replacements for the GCC intrinsics. I was able to compile Redner using Visual Studio 2019 today and successfully interfaced with the renderer using the Python bindings. |
This is merged. GPU support still needs some work so not closing this issue yet. I also need to figure out a way to publish windows pip packages. |
Thanks for merging! I will look into GPU support the next weeks. At least in theory it shouldn't be too hard. EDIT: Ok, the problem with using CUDA as language is that you cannot compile cpp files with NVCC that way. That's probably the issue you've run into. EDIT 2: I was able to compile the GPU version on Windows and get it running. I figured, it would be easiest to modify the pybind scripts, so introducing a new function called |
Thank you for the excellent work! I am able to build and run the forward rendering examples on Windows successfully. Are there any updates on how to run with GPU version on Windows? |
That's great news!
This is however not. Tbh, I didn't try the backprop samples under Windows yet but a functional backpropagation is also crucial for my use case. So I will probably also run into this issue soon, thanks for the warning.
I managed to get the GPU version to compile under Windows and also built the python package. From what I've tested, deferred rendering works as expected but path tracing does not. Essentially something triggers a segmentation fault. I did dive deeper into the issue and traced it back to For now, I find a fully working CPU version more important, so I'll probably look into that first. EDIT: You are right. Backpropagation does not work under Windows. Created an issue (#93). |
@guanming001 GPU support is now added for Windows builds. Unfortunately, path tracing currently does not work, but at least the albedo and deferred rendering operations (as well as backpropagation with these). If you encounter weird linking issues (e.g. VS trying to link against |
Windows machines should be able to |
Build script is target on gcc and linux currently.
Is there any plan to port to Windows and MSVC?
The text was updated successfully, but these errors were encountered: