Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pspm_write_channel variable assignment #421

Closed
teddychao opened this issue Nov 18, 2022 · 1 comment · Fixed by #689
Closed

pspm_write_channel variable assignment #421

teddychao opened this issue Nov 18, 2022 · 1 comment · Fixed by #689
Assignees
Labels
Conceptional The pull request includes conceptional updates
Milestone

Comments

@teddychao
Copy link
Contributor

Recent development of PsPM aims at generalising the variable options in all pspm functions. channel_action, one of the subfields of options, has been generalised for every function except for pspm_write_channel. For every other function, channel_action is a subfield in options, and it can be whether mandatory or optional. For pspm_write_channel, channel_action is an individual variable which is parallel to options. This is an exception for channel_action and we may want to reconsider where to put it.

We have discussed about this issue in this week's group meeting. Our colleagues have provided their suggestions:

  • One of our colleagues suggested channel_action should be prioritised in pspm_write_channel because it plays a vital role in the process of pspm_write_channel. As an individual variable, it will cause attention of users and force them to always provide value for it.
  • Another colleague suggested channel_action could be renamed in pspm_write_channel. This is because throughout PsPM, options always tends to have the field channel_action when applicable. Users may become confused whether to specify such value in the individual variable of pspm_write_channel or the field of options in pspm_write_channel.
@teddychao
Copy link
Contributor Author

Hi @fedmanci and @SerenXia I have put your comments on our last meeting to this issue. I hope this is exactly what you suggest. Please feel free to comment if there is any information missing. It would be grateful if you can let us know your thoughts about this issue @dominikbach . Thanks.

@dominikbach dominikbach added this to the v6.2 milestone Aug 15, 2023
@teddychao teddychao modified the milestones: v6.1.1, v6.2 Jan 22, 2024
@teddychao teddychao added the Conceptional The pull request includes conceptional updates label Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Conceptional The pull request includes conceptional updates
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants