Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Break source code into multiple files #80

Closed
bwbeach opened this issue Mar 6, 2016 · 3 comments
Closed

Break source code into multiple files #80

bwbeach opened this issue Mar 6, 2016 · 3 comments

Comments

@bwbeach
Copy link
Contributor

bwbeach commented Mar 6, 2016

Having all of the code in a single file is awkward. And now that it can be installed with pip, there is no longer a need to have it all in a single file to make downloading easy.

@bwbeach
Copy link
Contributor Author

bwbeach commented Mar 6, 2016

For unit tests, we can make a tests directory, and setup.py will know how to run them.

I'm not sure how to test running it as a command. Once we have unit tests, they can handle most of the testing of the internal logic, but I'd still like to have a way to test passing in command-line arguments. We probably need just a couple test cases for it.

One thing I've seen is to have a test script that sets PYTHONPATH to the source directory, and then uses "python -m" to run the module as a command line. I think this might work.

@ppolewicz
Copy link
Collaborator

Travis CI already installs the command line tool, so adding it to PYTHONPATH should not be needed in such case.

We should sync all forks before breaking down the file into pieces. I don't have much in the works currently. Do you plan to cut it any time soon? I think it is better if you do it (given the IDEs that we use).

@bwbeach
Copy link
Contributor Author

bwbeach commented Mar 7, 2016

It looks like there's not much happening now. I'll plan on breaking up the code Monday afternoon (Hawaii time), which is very early Tuesday morning UTC.

If that will cause conflicts, let me know.

@bwbeach bwbeach closed this as completed Mar 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants