Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix async load bug for synchronous templates #141

Merged
merged 2 commits into from Aug 23, 2012

Conversation

chewbranca
Copy link
Contributor

This fixes a bug where templates already loaded into JST would be improperly declared as async templates, resulting in the async deferred to never be resolved, and the view to never be rendered.

@tbranyen
Copy link
Owner

@chewbranca The only issue I'm facing here is that this will not validate through JSLint. The variable you're defining is enclosed in a block. If you could define it at the top of the function and then assign it inside the else that would be totally legit.

@chewbranca
Copy link
Contributor Author

Sure, I'll get that changed here in a few.

On Wed, Aug 22, 2012 at 4:13 PM, Tim Branyen notifications@github.comwrote:

@chewbranca https://github.com/chewbranca The only issue I'm facing
here is that this will not validate through JSLint. The variable you're
defining is enclosed in a block. If you could define it at the top of the
function and then assign it inside the else that would be totally legit.


Reply to this email directly or view it on GitHubhttps://github.com//pull/141#issuecomment-7955280.

@duro
Copy link

duro commented Aug 23, 2012

Yep, this needs to be pulled. This fixed an issue that was causing my bbb builds to fail. Thanks for finding the fix for this.

@tbranyen
Copy link
Owner

Thanks man!

tbranyen added a commit that referenced this pull request Aug 23, 2012
Fix async load bug for synchronous templates
@tbranyen tbranyen merged commit 516487c into tbranyen:master Aug 23, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants