Split Namespace Declaration from Application Entry Point #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Splitting these into two files and controlling their load order makes the
boilerplate more flexible by allowing entry to be bound to something other
than jQuery(function($){ . This is useful for jquery mobile projects, for
instance.
|
Hrm perhaps naming the namespace file, |
See previous commit message for more details.
|
That'd be fine - I'm new to git. Used to working with hg / Mercurial. Left a couple of files out of this commit. Will try to make my next pull request a little cleaner :-) |
Namespace is defined in app/namespace.js, app init is defined in index.js. Load order in index.html and build/config.js were changed to: app/namespace.js app/modules/*.js app/index.js
|
I believe this second go-around is cleaner. Files are named as you requested. |
|
Looks good, thanks man! |
tbranyen
added a commit
that referenced
this pull request
Jan 23, 2012
Split Namespace Declaration from Application Entry Point
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Putting these in two separate files (index.js = namespace declaration, app.js = app entry point) and changing load order to:
app/index.js
app/modules/*.js
app/app.js
makes for a more flexible solution that allows the app to be initialized on some event other than jQuery(document).ready()
This is helpful, for instance, for jquery mobile projects, where the app may need to be initialized before jQuery(document).ready() fires.
See here for more info: azicchetti/jquerymobile-router#12 (comment)