SubRoute causes routes to get evaluated multiple times

[rweng]

So I have this MainRouter.js:

var Router = Backbone.Router.extend({
            routes: {
                '': "root",
                users: "users",
                test: 'test',
                '*actions': 'defaultRoute'
            },

            test: function () {
                debugger;
            },

             createSubRouters: function () {
                require(['routers/CompanyRouter'], function (Router) {
                    new Router('companies', {createTrailingSlashRoutes: true});
                });
                 ...
             }

The router is loaded in an Marionette App, like this:
app.js:

           app.addInitializer(function () {
                // we require the router here to avoid circular dependencies
                require(['routers/MainRouter'], function (Router) {
                    app.router = new Router();
                    Backbone.history.start();
                    app.router.createSubRouters();
                })
            });

When I go on #/test, the debugger is triggered when starting the history in app.js.
However, when the subrouters are created, Backbone.history.loadUrl (https://github.com/ModelN/backbone.subroute/blob/master/backbone.subroute.js#L81) causes the function to be executed again.

This means, that when I first time load my app, the controller/router function is executed (1 + numberOfSubRouters) times.

Can I avoid this somehow? I tried to move the app.router.createSubRouters(); before the Backbone.history.start(), but with no success.

Any help is greatly appreciated :)

[geekdave]

Hi Robin,

I just pushed v0.3.2 which should fix this issue. Basically that call to loadUrl should only have been invoked if the browser url hash actually matches the subroute being initialized. I didn't run into this myself because I am lazy-loading my sub-routes, only when they are first navigated to.

Please let me know if this fixes the issue for you.

Thanks,
Dave

[rweng]

@geekdave Jep, it does. Thank you!