Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[META] List of blocking issues for Drupal that we should also look at #36

Closed
5 of 6 tasks
jenlampton opened this issue Jul 3, 2023 · 4 comments
Closed
5 of 6 tasks

Comments

@jenlampton
Copy link
Member

jenlampton commented Jul 3, 2023

I'm making a list of these issues for one of my client projects, so I thought I could document them here also. I believe we already have issues for some of these things, and some of them have already been fixed for Backdrop, so I won't make the individual issues yet, but I'll include the d.o links for reference.

Prioritized list

Other things we should look at

@olafgrabienski
Copy link
Member

olafgrabienski commented Aug 11, 2023

Not sure if to consider as 'blocking', but at least a regression: So far, CKEditor 5 doesn't support Full-screen editing.

Should this be mentioned in in the list above, or is it worth a separate issue?

More info:

@olafgrabienski
Copy link
Member

An update re CKE5 removes empty inline elements (icons added with <i></i>:
This issue is fixed in Drupal by upgrading CKEditor 5 to version 39, see https://www.drupal.org/node/3379650.

@quicksketch
Copy link
Member

CKE5 removes width & height attributes on <img>

This seems to have been fixed in v.40.0.0

No styles on block-level elements

This was fixed in ckeditor/ckeditor5#13341, CKEditor v38.0.0

CKE5 removes <a>s that wrap HTML elements not natively supported by CKEditor 5

This was fixed in 38.x.x (not sure which version but upgrading to 40+ should do the trick)


So after updating CKEditor to v40+, all our blocking issues should be resolved, other than full-screen editing, which does not yet exist upstream.

@quicksketch
Copy link
Member

Since all other issues have been addressed, let's split out full screen support into its own issue: #76

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants