Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mobile #23

Closed
laryn opened this issue Jul 6, 2022 · 1 comment
Closed

Mobile #23

laryn opened this issue Jul 6, 2022 · 1 comment

Comments

@laryn
Copy link
Member

laryn commented Jul 6, 2022

I am trying to help my kids post something and find that cropping doesn’t work from a phone. It seems like it could or should.

see also https://www.drupal.org/project/manualcrop/issues/2313353
@laryn laryn closed this as completed in ba4f8d1 May 30, 2023
@laryn
Copy link
Member Author

laryn commented May 30, 2023

With the latest (although still very old) version of ImgAreaSelect, which is in that wrapper module now, touch should be supported. Thanks to this tip from a patch by peximo in the D7 queue, I've made an adjustment here and bumped the requirement on the ImgAreaSelect wrapper module to make sure it's on the latest version.

peximo: The main issue is that moving from v0.9 to 1.0 imgAreaSelect adds a pixel to the lower right corner in setSelection() which ultimately caused the initial selection of ManualCrop to be empty.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@laryn