Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using the image library in a modal edit doesn't work #152

Closed
laryn opened this issue Jan 29, 2023 · 4 comments
Closed

Using the image library in a modal edit doesn't work #152

laryn opened this issue Jan 29, 2023 · 4 comments
Labels
bug Something isn't working

Comments

@laryn
Copy link
Member

laryn commented Jan 29, 2023

When you select the image from the library and try to insert it, the modal closes completely without saving.

@olafgrabienski
Copy link
Member

Confirmed (just stumbled upon it on a new site)! @laryn Do you already have plans (or an idea, how) to fix the issue?

@laryn
Copy link
Member Author

laryn commented Jun 30, 2023

@olafgrabienski I do have plans to fix it but haven't had any time to even start digging into it. I'm guessing it will require some Javascript. I'm also open to additional information being added here, or PRs, or ?? 😄

@laryn
Copy link
Member Author

laryn commented Aug 16, 2023

Further information:

  • On an image field, the image library does not work. Once the image is selected the modal closes without sending the image back to the image field.
  • On a rich text field, using the image library via the CKEditor button does work as expected.

The difference appears to be that CKEditor pops up a separate modal, so when that closes the original modal is still there. The image field doesn't open in a new modal, it reloads the library in the same initial modal, and when that closes there is nothing left.

@laryn
Copy link
Member Author

laryn commented Oct 1, 2023

This appears to be a core issue which now has a working PR -- closing this issue.

@laryn laryn closed this as completed Oct 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants